Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked JSON template #25

Merged
merged 10 commits into from May 30, 2017
Merged

Reworked JSON template #25

merged 10 commits into from May 30, 2017

Conversation

RosemaryOrchard
Copy link
Contributor

Rewritten from the ground up instead of based on the RSS template.

Copy link
Member

@rhukster rhukster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the valid types. Thanks!

feed.php Outdated
@@ -28,7 +28,7 @@ class FeedPlugin extends Plugin
/**
* @var array
*/
protected $valid_types = array('rss','atom');
protected $valid_types = array('rss','atom','json');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this from the standard list on purpose. It's added back if the configuration has the json feed support enabled.

@RosemaryOrchard
Copy link
Contributor Author

Sorry, it was supposed to take all of your files instead of merging!

@rhukster rhukster merged commit c0efac3 into getgrav:develop May 30, 2017
@rhukster
Copy link
Member

released! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants