-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for dash separated locales - en-US, zh-TW, zh-CN etc. #6
Comments
I'm not sure how this is possible. It simply grabs the languages as they exist in the languages object: https://github.com/getgrav/grav-plugin-langswitcher/blob/develop/langswitcher.php#L61 and then just loops over them: Can you add a |
@rhukster thanks for quick reply - appreciate it! It looks like it's there but for some reason he doesn't display it on front-end. |
what does your |
@rhukster first 17 lines of my user/config/system.yaml:
|
Yah i don't think Grav likes it when you mix types (ie xx and xx-xx). What happens if you remove |
If I remove I changed the format and made them standing in one array like this - |
Actually.... i think i know the problem, it's a limitation of https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Language/LanguageCodes.php Would you mind opening up an issue here: https://github.com/getgrav/grav/issues for this specifically? |
So I added
zh-TW
but langswitcher doesn't show it in navigation.zh
alone works so I suspect you cover a language but not all locales. Please add them too as I would like to have both Chinese Traditional (zh-TW
) and Chinese Simplified (zh-CN
) on my site.The text was updated successfully, but these errors were encountered: