Added additional checks for GD image library #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to have GD installed without JPEG support. Without JPEG support in GD image manipulation of JPEG images will result in the fallback image being displayed. But no errors will propagate to the logs or debugger, even with all error reporting on. In my case, I used the official PHP docker 7.2.9-cli-alpine3.8 and installed gd with their helper script docker-php-ext-install. However, this installs GD without jpeg support. Since there were no errors it was a long rabbit hole I had to jump down before I found that jpeg image types weren't being supported.
Added warning notification class support for notifications that don't rise to errors, but could affect the functionality of the site.
|
mering this manually into new 2.0 feature branch |
rhukster
added a commit
that referenced
this pull request
Sep 19, 2018
* rewrite!!! * Better display support * bolder styling * Added SCSS and restyled for beauty :) * more improvements * footer * smaller logo * This should be working… * Added a load() method * Removed ‘test’ ::load() * cleanup… * Add event to support other plugins adding problems * improvements * fixes #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have GD installed without JPEG support.
Without JPEG support in GD image manipulation of JPEG images will result in the fallback image being displayed. But no errors will propagate to the logs or debugger, even with all error reporting on.
In my case, I used the official PHP docker 7.2.9-cli-alpine3.8 and installed gd with their helper script docker-php-ext-install. However, this installs GD without jpeg support.
Since there were no errors it was a long rabbit hole I had to jump down before I found that jpeg image types weren't being supported.