Concatenate 'px' to $size only if $size is numeric (#63)

Non-numeric values of size, eg 'x-large', get passed through without alteration
getgrav · Mar 20, 2019 · b44ec54 · b44ec54
1 parent 64e5e5f
commit b44ec54
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/shortcodes/SizeShortcode.php b/shortcodes/SizeShortcode.php
@@ -9,7 +9,8 @@ public function init()
     {
         $this->shortcode->getHandlers()->add('size', function(ShortcodeInterface $sc) {
             $size = $sc->getParameter('size', $this->getBbCode($sc));
-            return '<span style="font-size: '.$size.'px;">'.$sc->getContent().'</span>';
+            if ( is_numeric($size) ) { $size = $size.'px' ; }
+            return '<span style="font-size: '.$size.';">'.$sc->getContent().'</span>';
         });
     }
-}
+}