Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something funky with Admin plugin and Shortcodes #26

Closed
Perlkonig opened this issue Jan 17, 2017 · 1 comment
Closed

Something funky with Admin plugin and Shortcodes #26

Perlkonig opened this issue Jan 17, 2017 · 1 comment

Comments

@Perlkonig
Copy link

Moved from here at @rhukster 's request.

I have a couple of shortcode plugins. I've received bug reports for Scheduler and Table Importer. It seems related to the Admin plugin somehow. I've done the following:

  1. I did a clean install of Grav only (no Admin).

  2. I then did bin/gpm install table-importer.

  3. I replaced default.md with the following and dropped in import.csv.

---
title: test
---

[u]Testing[/u]

[ti file=import.csv /]
  1. It works as expected.

  2. I then downloaded and installed Grav+Admin and immediately did bin/gpm install table-importer.

  3. I added some dump() statements to table-importer.php.

  4. I then dropped in the exact same markdown and csv.

  5. It fails.

So it appears the onShortcodeHandlers isn't getting called for some reason, but the [u] code is working. Any ideas?

@rhukster
Copy link
Member

See my PR. Fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants