Added check for ACL in Header of pages when searching #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flaviocopes Can we please get this merged ASAP and release of new version of this plugin done? Thank you very much. |
|
@rbukovansky I am not really into PHP and grav plugins yet, so you might want to improve/refactor the code. I think there could be couple of improvements, especially for the more less duplicated code from login plugin. Maybe there should be a general function to do this filtering in the "core?!", if this would be possible... |
|
@NilsEngelbach Well, I'm not a dev at all... I've just asked @flaviocopes to merge the changes and please to do a proper release... That's all. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SimpleSearch Plugin returns results for pages that are protected by ACL Rules like
It is not enough to filter the results in the twig template for search results, since there is also an json formatted endpoint (/search.json/query:Example).