-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Default values, use link instead of permaLink #28
Conversation
mhauri
commented
Jan 26, 2017
- Set default values for "changefreq" and "priority" and use them.
- Use $page->link(true) instead of $page->permaLink()
What's the reason behind Use $page->link(true) instead of $page->permaLink() ? |
Didn't tested it trough, but noticed a Problem in my Blog. As Example in my Blog I have a folder 01.blog in which i have my blog posts. Also the Homepage itself contains the /blog folder in the sitemap. |
|
This patch is really needed to make the grav sitemap plug-in functional. Thanks @mhauri ! I've patched my local install manually. Thanks a lot (and sorry for any inconvenience here), guys! |
I also think it should be canonical as it supports languages. |
FYI: link code is simply:
Canonical code is:
so |