Update iframe URLs to always use HTTPS #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey All, Could we get a release published that includes this change? There hasn't been any other commits to the plugin since this one on June 9 (nor any commits other than this one since the 2.0.3 release), and I'd really like to have this issue officially resolved. |
|
Done. Lots of updates are pending releases.. i'm starting to go through the repos now and get stuff out. |
|
Thanks, Andy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey All,
I'm applying a content security policy to a website I'm working on that only allows iframes to be embedded from
https://www.youtube.com. When working on a dev version of the site on my local machine, the iframe fails to load because the plugin currently uses protocol-relative URLs and I am not developing in an HTTPS environment.Additionally, YouTube enforces a redirect from HTTP -> HTTPS, so a protocol-relative URL only adds unnecessary overhead when loading a video on a Grav site served over HTTP.
To resolve these issues, this pull request updates the plugin to always use HTTPS URLs for YouTube.
Regards,
--- Scott