Move deferred javascript assets #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2020
|
@gizmecano ive made a new commit to develop to modernize and fix the assets to best common practices. Can you check it works well in your site too. Tested using the skeleton |
|
As I have now made several changes which split up quite clearly from the initial repository, I will have to compare your own modifications carefully enough to integrate and test them in my working draft. I would tell you if everything works. Thanks for taking the time to watch this pull request. |
|
I just tested the recent upgrades you made in commit 7c08fbb (adapting them to my own changes) on my development environment (a local testing blog) and everything seems to be properly working. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes made in the version 1.4 (related to deffered assets), I noticed that some specific features related to
.post-image-imageand.teaserimage-imageclasses don't work properly.Moving the bottom block from
base.html.twigintojavascripts.html.twigtemplate seems to reorder rightly assets in order to run script which needed by these classes.