config: Auto metadata from Exif: throwing error when switched on #2248

MattAppleton · 2018-11-01T20:24:37Z

This error has been tested on a completely vanilla / untouched install of Grav v1.5.3 - Admin v1.8.12

If we add an image WITH a metadata description / creator / keyword using the admin in 'normal' mode it throws an error like this, and the image doesn't appear to view...

Opening file for writing failed on error fopen(user://...@2x.jpg.meta.yaml): failed to open stream: "\RocketTheme\Toolbox\StreamWrapper\ReadOnlyStream::stream_open" call failed

adding a keyword-less file is fine and doesn’t prompt errors if added to a page…! Seems like a bug or am I being daft?!

if we click out of the page and back in in 'expert' mode (not 'normal' mode) the page does seem to behave OK though...

The text was updated successfully, but these errors were encountered:

rhukster · 2018-11-03T17:14:37Z

I will look into this.

rhukster · 2018-11-03T20:48:52Z

Can you please upload an image (or email me one) that is causing the issue. I just tested a sample image and it worked.

NOTE: You have to 'save' the page first before the metadata file is created.

original:

rhukster · 2018-11-03T20:54:00Z

Also works for me if i append @2x for a retina image.

MattAppleton · 2018-11-03T22:03:17Z

Will do, just firing up my testbed so I can check exactly what was throwing the error.

MattAppleton · 2018-11-03T22:06:23Z

MattAppleton · 2018-11-03T22:07:06Z

this image has 'landscape' in the keyword IPTC core metadata

MattAppleton · 2018-11-03T22:08:49Z

If I add it via the admin to GRAV I get various error screens like this...

MattAppleton · 2018-11-03T22:13:48Z

There problem occurs when I hit 'save', then the red error screen persists. I am able to see that the file has been ingested looking at the .md file, but the 'normal' admin view > page media field shows no image content at all. And no metadata.yaml feel is added to the relevant folder.

MattAppleton · 2018-11-03T22:19:32Z

Andy - -selection of photos all of which throw errors when uploading, but ONLY if the exif feature is toggled ‘ON’… each one has a keyword plus usual basic metatdata.

…

On 3 Nov 2018, at 20:48, Andy Miller ***@***.***> wrote: Can you please upload an image (or email me one) that is causing the issue. I just tested a sample image and it worked. NOTE: You have to 'save' the page first before the metadata file is created. <https://user-images.githubusercontent.com/1084697/47957225-8af1ba00-df77-11e8-8686-19c8590ebb07.png> original: <https://user-images.githubusercontent.com/1084697/47957227-904f0480-df77-11e8-9133-f043a766e1ea.jpg> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2248 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGAQniHe4rHMhr1VZ9n_BBOPFIW7vC3tks5urgE7gaJpZM4YI9N2>.

rhukster · 2018-11-04T00:26:01Z

I tried your image above, and uploaded and saved just fine: Created a yaml file with:

Orientation: 1
ColorSpace: 65535
keywords: landscape

rhukster · 2018-11-04T00:27:22Z

I'm not sure what you are doing differently from me. I'm running on PHP 7.2 with exif enabled in PHP config:

MattAppleton · 2018-11-04T10:22:27Z

Strange I am running 1.6 beta Grav with Quark theme as testbed1, just trying to add image into page with default template...? Will check php version, on MAMP it is definitely 7.2... Sent from Matt's mobile

…

On 4 Nov 2018, at 00:27, Andy Miller ***@***.***> wrote: I'm not sure what you are doing differently from me. I'm running on PHP 7.2 with exif enabled in PHP config: — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

MattAppleton · 2018-11-04T22:16:41Z

OK, so trying to unpick this further...

On a Linode / Serverpilot box running
Grav v1.6.0-beta.4 - Admin v1.9.0-beta.4 (fresh install this evening)
PHP Version 7.2.11
EXIF Version | 7.2.11

I get the aforementioned errors when operating via the Admin plugin interface (ie adding images via admin interface) - - this is ONE exampel of the error message panels thrown, the other wont let me copy/paste
"Opening file for writing failed on error fopen(user://...@2x.jpg.meta.yaml): failed to open stream: "\RocketTheme\Toolbox\StreamWrapper\ReadOnlyStream::stream_open" call failed

on an older install
on SAME Linode Serverpilot box running
Grav v1.4.0-rc.1 - Admin v1.7.0-rc.2
PHP Version 7.2.11
EXIF Version 7.2.11
I DONT get these errors... ?!

install 1 (exif problems, seem to bit intermittent after a break though, ie if I come back later I can 'see' the image in the admin):
https://private.modernactivity.com/GRAV/

install #2 (no problems
https://sandbox.modernactivity.com/grav-admin_Feb_base/

MattAppleton · 2018-11-06T20:58:48Z

Had a moment to check in on this again. If I revisit the site admin on install #1 (https://private.modernactivity.com/GRAV/) on a different machine ./ new session, I do NOT get an error in admin view, I can see the image in the relevant post/.page.

BUT if I try adding a new image to a new page I get the same issue, red error opens and an 'invisible' image that has beed added to the site, but not been recognized by the admin, with no meta.yaml generated...

MattAppleton · 2018-11-06T21:01:42Z

If I then clear cache / refresh and revisit the page in admin, it does work. Interestingly, it is only at that point that the meta.yaml is generated, so some time AFTER the image is added... basically the meta.yaml only seems to be generated on the second 'fresh' admin page visit.

rhukster · 2018-11-06T21:27:15Z

ok that's useful information that should help me diagnose the issue... thanks.

MattAppleton · 2018-11-06T21:31:24Z

thanks for looking at this...

just ran latest Quark update on install #1, issue still live tho'

MattAppleton · 2018-12-04T23:44:56Z

Hi there — perhaps this is something being looked at with GRAV 2, but just wanted to say that the latest stable GRAV / Admin plugin / Quark still gives us the issue (red panel, disappearing images in admin) when eddying images with IPTC metadata.

And trying the same procedure with

Grav v1.6.0-beta.6 - Admin v1.9.0-beta.6 - latest beta Quark - - same issue when adding images with embedded metadata...

MattAppleton · 2019-03-15T23:40:08Z

Hullo

I am still getting the same 'red panel on upload' errors when trying to add an image with keyword metadata: https://private.modernactivity.com/GRAV/test-pic_tues_02

As before, clearing cache and refreshing seems to help. But the issue is driving clients mad, as they want to keep using caption functions that express caption info held on the image file itself!

untouched plain install of Grav v1.6.0-rc.3 - Admin v1.9.0-rc.3

MattAppleton · 2019-03-15T23:55:20Z

the 'stable' install does NOT encounter the issue still
Grav v1.4.0-rc.1 - Admin v1.7.0-rc.2

BUT when going to
Grav v1.5.8 - Admin v1.8.19

Image error panel appears when uploading keyword-tagged image.

rhukster · 2019-03-16T00:58:01Z

Ok, try this, around line 174 in system/src/Grav/Common/Page/Media.php, replace the existing if statement with this

                    if ($meta_trimmed) {
                        $full_meta_path = Grav::instance()['locator']->findResource($meta_path, true, true);
                        $file = File::instance($full_meta_path);
                        $file->save(Yaml::dump($meta_trimmed));
                        $types['meta']['file'] = $meta_path;
                    }

MattAppleton · 2019-03-19T17:52:13Z

@rhukster — Amazing work Andy, thus far it has solved exif-related media upload issues on my testbed install, will try it on a few other instances...

MattAppleton · 2019-04-23T22:17:34Z

just to say - -my recent testing checks out well, I think this issue solved, great work with current v1.6!

rhukster · 2019-04-23T22:42:48Z

Phew, saw this come in and thought it was a new issue!

bricebou · 2020-04-16T06:58:46Z

Hi,

It finally works both on localhost and on a shared hosting... But I don't know it it's the change of the if statement mentioned below or anything else...
And there are several unknown causes :

definitely an issue with cache : I have to clear the cache for the exif metadata to be accessible ;
it seems I can't make exif auto metadata alongside with the Admin Addon Media Rename.

I'm using the latest stable Grav + Admin plugin package, on a local Debian Buster ; all requirements are "green" in the Tools > Reports page.

By the way, it seems that the conversion from coordinates in degrees to decimal values are quite buggy...

MattAppleton changed the title ~~config: Auto metadata from Exif: ON throwing error~~ config: Auto metadata from Exif: throwing error when switched on Nov 1, 2018

rhukster self-assigned this Nov 3, 2018

rhukster added the evaluating label Nov 3, 2018

rhukster added the cannot replicate label Nov 3, 2018

rhukster added a commit that referenced this issue Mar 16, 2019

Hopefully fix auto_metadata_exif error #2248

81efef7

MattAppleton closed this as completed Apr 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config: Auto metadata from Exif: throwing error when switched on #2248

config: Auto metadata from Exif: throwing error when switched on #2248

MattAppleton commented Nov 1, 2018 •

edited

rhukster commented Nov 3, 2018

rhukster commented Nov 3, 2018

rhukster commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018 •

edited

MattAppleton commented Nov 3, 2018 via email

rhukster commented Nov 4, 2018

rhukster commented Nov 4, 2018

MattAppleton commented Nov 4, 2018 via email

MattAppleton commented Nov 4, 2018

MattAppleton commented Nov 6, 2018 •

edited

MattAppleton commented Nov 6, 2018 •

edited

rhukster commented Nov 6, 2018

MattAppleton commented Nov 6, 2018

MattAppleton commented Dec 4, 2018

MattAppleton commented Mar 15, 2019

MattAppleton commented Mar 15, 2019

rhukster commented Mar 16, 2019

MattAppleton commented Mar 19, 2019

MattAppleton commented Apr 23, 2019

rhukster commented Apr 23, 2019

bricebou commented Apr 16, 2020

config: Auto metadata from Exif: throwing error when switched on #2248

config: Auto metadata from Exif: throwing error when switched on #2248

Comments

MattAppleton commented Nov 1, 2018 • edited

rhukster commented Nov 3, 2018

rhukster commented Nov 3, 2018

rhukster commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018

MattAppleton commented Nov 3, 2018 • edited

MattAppleton commented Nov 3, 2018 via email

rhukster commented Nov 4, 2018

rhukster commented Nov 4, 2018

MattAppleton commented Nov 4, 2018 via email

MattAppleton commented Nov 4, 2018

MattAppleton commented Nov 6, 2018 • edited

MattAppleton commented Nov 6, 2018 • edited

rhukster commented Nov 6, 2018

MattAppleton commented Nov 6, 2018

MattAppleton commented Dec 4, 2018

MattAppleton commented Mar 15, 2019

MattAppleton commented Mar 15, 2019

rhukster commented Mar 16, 2019

MattAppleton commented Mar 19, 2019

MattAppleton commented Apr 23, 2019

rhukster commented Apr 23, 2019

bricebou commented Apr 16, 2020

MattAppleton commented Nov 1, 2018 •

edited

MattAppleton commented Nov 3, 2018 •

edited

MattAppleton commented Nov 6, 2018 •

edited

MattAppleton commented Nov 6, 2018 •

edited