Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted asset types to enable extension of asset classes #2937

Merged
merged 1 commit into from Jun 22, 2020

Conversation

jackthomasatl
Copy link
Contributor

No description provided.

@rhukster
Copy link
Member

What is the specific use case for extending assets class?

@jackthomasatl
Copy link
Contributor Author

I'd like to handle my front-end assets differently. Are you against the idea of extending grav?

I'm using s3 to store my assets instead of local.

@jackthomasatl jackthomasatl changed the title Adjusted asset types to enable extension of assets class Adjusted asset types to enable extension of asset classes Jun 22, 2020
@jackthomasatl
Copy link
Contributor Author

Currently I apply this change via patch file when I build my local. I'd like to see it as part of the official source.

@ricardo118
Copy link
Contributor

if you have the assets externally, do you even need to use grav's assets?

@rhukster
Copy link
Member

I actually don't have a problem making this more extensible, i was really just curious :)

@rhukster rhukster merged commit 25461f7 into getgrav:1.7 Jun 22, 2020
@jackthomasatl
Copy link
Contributor Author

jackthomasatl commented Jun 22, 2020

I hear that, I moved my docroot folder above the base directory. For images I host the content via s3 and css files I host them locally but have the webroot deeper into the folder structure. I've got an extension of BaseUtils that modifies the uri method and I've also got extensions to the Assets and Medium classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants