Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for timeout in selfupgrade command #3013

Merged
merged 2 commits into from Oct 30, 2020

Conversation

grantholle
Copy link
Contributor

Upgrading from a server within China was brutally slow. It couldn't update without timing out. This adds an option on the selfupgrade command to accommodate a timeout value for downloading the update.

@mahagr
Copy link
Member

mahagr commented Sep 22, 2020

Default timeout should be at least 30 seconds IMHO.

@grantholle
Copy link
Contributor Author

15 is the default in the Response class, which is what I based the default on here. I agree that 15 is pretty small.

Copy link
Member

@mahagr mahagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me.

I would still raise the default timeout limit to 30 seconds as your connection may be slow.

@grantholle
Copy link
Contributor Author

Raised it to 30

@grantholle
Copy link
Contributor Author

Any word on getting this approved?

@rhukster rhukster merged commit 6a6f99e into getgrav:develop Oct 30, 2020
@rhukster
Copy link
Member

Merged!

@grantholle grantholle deleted the selfupgrade-timeout branch December 17, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants