Add SRI integrity hash to assets #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, thanks! |
w00fz
approved these changes
Mar 5, 2021
mahagr
reviewed
Mar 8, 2021
|
|
||
| if ( !empty($assetsConfig['enable_asset_sri']) && $assetsConfig['enable_asset_sri'] ) | ||
| { | ||
| $dataToHash = file_get_contents( GRAV_ROOT . $input); |
There was a problem hiding this comment.
@w00fz I think we should cache this part and maybe just check file modification time when hash recalculation isn't needed.
There was a problem hiding this comment.
Yeah I agree, also it should probably also use the Grav File instance and locator for the asset content and path, rather than file_get_contents
There was a problem hiding this comment.
We can probably merge then optimized to be honest.
rhukster
approved these changes
Mar 8, 2021
|
|
||
| if ( !empty($assetsConfig['enable_asset_sri']) && $assetsConfig['enable_asset_sri'] ) | ||
| { | ||
| $dataToHash = file_get_contents( GRAV_ROOT . $input); |
There was a problem hiding this comment.
We can probably merge then optimized to be honest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the website pre-generated and hosted on a CDN, I would like to have integrity hashes included in CSS and JS assets.
This PR will allow:
system.assets.enable_asset_sriconfig option