fix: avoid overriding vcs user name

[morgante]

Fix an oversight in #373 where we accidentally overwrite input data.

Greptile Summary

This is an auto-generated summary

• Prevented VCS user name from being overwritten in input data
• Ensured VCS user name is only inserted if not already present

Summary by CodeRabbit

• New Features
  • Improved logic for handling key-value pairs in workflows to ensure only necessary updates are made, enhancing performance and accuracy.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes in workflows.rs focus on enhancing the function logic within run_remote_workflow by adding conditional insertion of a key-value pair into a map. This ensures that the insertion happens only if the key already exists, thereby avoiding redundant entries and potential errors.

Changes

File	Summary
crates/cli/src/workflows.rs	Added conditional insertion of key-value pairs in the map within run_remote_workflow function. This logic checks if the key exists before inserting the value.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 675d2ed and 495020f.

Files selected for processing (1)

• crates/cli/src/workflows.rs (2 hunks)

Additional context used

Learnings (1)

Common learnings

User: morgante
URL: https://github.com/getgrit/gritql/pull/231

Timestamp: 2024-04-15T05:47:47.743Z
Learning: User morgante prefers not to be asked for documentation.

Additional comments not posted (2)

crates/cli/src/workflows.rs (2)

112-115: The conditional insertion logic to avoid overwriting the VCS user name is well-implemented and follows the PR's objective.

---

236-238: The addition of conditional logic in run_remote_workflow to prevent overriding the VCS user name is consistent with the changes in run_bin_workflow and aligns with the PR's objectives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[greptile-apps]

LGTM