Add forward and background arrows to canvas to undo/redo #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Addressed comments from PR Added background color for copied region Replacement should happen on defaulted value, not unsafe ref. Using 1/4em unicode spaces so individuals can format names as they like. webpack-dev-server should be exactly at 1.14.0 It shouldn't be possible for a non-hovered metric card to be in the editing state. fixed node modules.
|
This ready to go in? I recall you saying it shouldn't be merged to master yet (but maybe you meant production?) |
* master: (27 commits) Added a comment to indicate some dead code. Renaming SimpleEditors as part of CR Basic changes for code review Add additional mac command key Stop breakage when empty cell is deleted Use NavHelper to ensure that backspace when nothing is selected will not go back in history MetricCardViewSection should always have relevant css attributes Force render of flowgrid on metric name change Cleaned text input css and made metric name not enterable when cannot be Catch event on undo Ensure that metric names update as is appropriate Refactor handleMouseDown and ensure that empty metrics are selected first click Fixed hasErrors mistype Only push updates of SimpleEditors when they are different than previous states Only render guesstimateForm if it is the correct metric Fixed a problem affecting dev where immutable invariants made space.organization a non-empty default object. Style TextInput correctly Removing broken npm deploy rules. TextForm editor should insertAtCaret with draftjs Fixing the persist edit state for the metric card name. ...
* master: Addressed comments form cr Pressing escape on name field should deselect Pressing enter on empty cell should not create new line Auto select metric card name and then value Css fixes to allow editing in Safari Remove undefined 'event' call in TextInput. Fixes firefox, safari. Eliminating unnecessary errors and using Signup for sign up. Disalow newlines in text value editor
| const spaceGraphSelector = state => { return _.pick(state, 'spaces', 'metrics', 'guesstimates', 'simulations', 'users', 'organizations', 'userOrganizationMemberships', 'me') } | ||
| const spaceSelector = (state, props) => {return state.spaces.find(s => s.id.toString() === props.spaceId.toString())} | ||
| function _sameId(idA, idB){ | ||
| return idA.toString() === idB.toString() |
There was a problem hiding this comment.
Why do we need this defensivity here?
There was a problem hiding this comment.
We need it for at least one of the IDs, I forgot which.
This was referenced Nov 16, 2022
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These work, but there are some improvements to make in future releases: