Probably needs a refactor later, but stops us from saving every key stroke. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,10 @@ class TextInputEditor extends Component { | |||
| return editorState.getCurrentContent().getPlainText('') | |||
| } | |||
|
|
|||
| _onBlur() { | |||
| this.props.onBlur(this.state.editorState.getCurrentContent().getPlainText('')) | |||
| } | |||
There was a problem hiding this comment.
Why does this need to pass the value to the parent? The parent element, TextInput, already has that value in state.value.
There was a problem hiding this comment.
No, it doesn't right now.
* master: Added stage environments for master, ozzie, matthew Addressed comments from cr Minor color alterations Added cut functionality to space header Basic refactoring for header Basic toolbar for space show header Adjusted model header to experiment Bit more clean up. Clean Up Don't try to update the graph at all, just tell the user to refresh. Partially updates the graph. Space warning, not properly updating graph. We shouldn't update an undefined name to a '' name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.