Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds visible error explanations for certain classes of errors. Closes 590. #609

Closed
wants to merge 17 commits into from

Conversation

mmcdermott
Copy link
Contributor

Staged on matthew.getguesstimate.com

Remaining AIs:

  1. Ensure error messages are acceptable.
  2. z-Index for error tooltip (and reposition to be below the card)
  3. Prevent INTERNAL_ERRORS from printing error messages (though this may not be necessary, as these rarely, if ever, occur).

@OAGr
Copy link
Member

OAGr commented Jul 17, 2016

  • Error tooltip needs to be brought up to the metric card file in order to resolve z-index issue.
  • Error tooltip is broken in metric modal. Fixing the above issue should help. I think for now we shouldn't show the error in the modal.
  • Error should show up whenever field is selected, not just on hover. It should also show as the user types. Right now it seems to only show after the user is done typing and re-selects that area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants