-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exampleSite: use go workspace pointing to local hinode clone #769
Conversation
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for your PR @deining, it looks like a more elegant solution. However, when validating the changes on my local machine, I wasn't able to render the example site properly. It works if I set [style]
purge = true Hinode uses |
a0d5b71
to
1f620ac
Compare
bf34eb8
to
cac40b7
Compare
With PR #786 merged, the infinite loop problem disappeared 😄.
I find this approach more natural than running the exampleSite from repo root via With this PR merged, npm run statements inside |
cac40b7
to
b7581d5
Compare
Thanks, it looks like a great improvement. However, when running this locally, I get the following error: Error: command error: failed to load modules: invalid modules list: "[..]/gethinode/hinode/exampleSite/_vendor/modules.txt" The content of
Tested with the following environment:
|
This PR was motivated from the experiences as described in #768: When I tried to run the example site, I found me confronted with an infinite loop while fetching dependencies. This PR resolves this issue by introducing a go workspace when running the example site. With this PR in place, you can change to the
exampleSite
dir and start the preview via: