Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize navbar offset #869

Merged
merged 6 commits into from Apr 3, 2024
Merged

Parameterize navbar offset #869

merged 6 commits into from Apr 3, 2024

Conversation

markdumay
Copy link
Collaborator

No description provided.

@markdumay markdumay added the enhancement New feature or request label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit a5a73fd
🔍 Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/660ce7ba9fb5340008cacdc9
😎 Deploy Preview https://deploy-preview-869--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (🔴 down 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit 40cdde0
🔍 Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/660cea7a77c481000761f696
😎 Deploy Preview https://deploy-preview-869--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (🔴 down 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@markdumay markdumay merged commit 2037a93 into main Apr 3, 2024
14 checks passed
Copy link

@vitabef vitabef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this change affects the logo—if a light and dark logo are applied, they are displayed as display:block, and the logo is not horizontally centered with the search form, causing the layout to immediately become misaligned. Please fix this bug!

@markdumay
Copy link
Collaborator Author

Unfortunately, this change affects the logo—if a light and dark logo are applied, they are displayed as display:block, and the logo is not horizontally centered with the search form, causing the layout to immediately become misaligned. Please fix this bug!

Sorry to hear this change introduced a bug. Could you please submit a bug report, including the steps how to reproduce this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants