-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Radarr widget incorrectly interprets isAvailable
#397
Comments
I originally reponded in "Sonarr and Radarr both say 0 wanted #43", but the issue is closed. I first responded and then realize the issue was closed. So I'm repeating here what I wrote in the other issue, hoping someone will make sense about what I'm explaining. I have mixted result. Depending on certain combination with "Min availability" and "Status", the movie will be "isAvailable: false" or "isAvailable: true"... Adding "Hancock 2" with min availability "Announced" status will be "Missing" and "isAvailable: true". For Radarr widget, Wanted should be counted with "sizeOnDisk = 0" and Have (Movies) counted with "sizeOnDisk > 0". Queued is working properly. |
isAvailable
I confirm that the [isAvailable] flag returned by the API is not the proper property that needs to be checked to determine the proper << WANTED >> movie count. I have tested the use of the [sizeOnDisk = 0] property and the SUM of the movies that have [sizeOnDisk = 0] gives us the proper and real << WANTED >> movie count. |
Please see #418 (comment) the Radarr app itself uses I suggest we use that, but I will leave it up to the PR author |
to me it's better to keep it simple : Wanted: sizeOnDisk = 0 if I read the code right, two arrays are constructed and counted and give Wanted and Have with those lines map: (data) => ({ It should be easy to replace item.isAvailable with item.sizeOnDisk and replace boolean with the proper number test. All this because Radarr's api lack a proper way to get Missing/Wanted movies. |
@Magelo to avoid any ambiguity, I made the widget behave just like Radarr's UI. I have added a new filed "Missing" to round out the available display options. Here's an example of what it will look like: |
It looks good @JazzFisch.
(I was affraid Monitored would be used to filter the list which would not be ok for me)
Makes sense! If I want it, it should be monitored and in my list with no files, but in my case isAvailable=true is showned "Statut=Missing" in Radarr and isAvailable=false is showned "Status=Not available" And in the end, missing movies are kind of Wanted too, not? Thanks for the modifications, hope to test this soon. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. |
You should count "sizeOnDisk": 0 to determined Wanted/Missing movies in a local Radarr Library.
Originally posted by @Magelo in #43 (comment)
The text was updated successfully, but these errors were encountered: