Enhancement: Add configurable refresh interval and points for glances service

[ni0ki]

Proposed change

Add support for configurable refresh interval and amounts of points for the Glances service widget.

-CPU:
  widget:
    type: glances
    url: http://url:port
    metric: cpu
    refreshInterval: 2500
    pointsLimit: 50

This opens 2 possibilities, mainly useful for people with a home that stays open for a long period:

• Reduce the number of API calls by increasing the interval.
• Have different monitored periods (see below)

A small note about network / disk
Information about IO/s for net (RX, TX) and disk (Read, Write) might seems strange, but is still correct. It will simply show the value for the immediate last refresh on glances' side, regardless of the configured interval

(I also alphabetically sorted the allowed keys to ease finding existing values)

Type of change

• New feature (non-breaking change which adds functionality)

Checklist:

• If adding a service widget or a change that requires it, I have added corresponding documentation changes.
• If adding a new widget I have reviewed the guidelines.
• I have checked that all code style checks pass using pre-commit hooks and linting checks with pnpm lint (see development guidelines).
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

Thanks. I can look at this later. It’s always debatable when a change has not been requested anywhere to know how valuable it would be for the community at large, but it is likely harmless.

In the meantime, please revert the alphabetizing change, it’s more useful to see them grouped by widget. Thanks

[ni0ki]

In the meantime, please revert the alphabetizing change, it’s more useful to see them grouped by widget. Thanks

Reverted. But I kindly disagree, as it's difficult to read in its current shape.
Maybe it should be organized by widget name to keep the grouping while making it clearer.

[shamoon]

You also didnt run the pre-commit hooks?

[shamoon]

I ran pre-commit and also organized the list a bit differently, I see your point about that

[ni0ki]

I ran pre-commit and also organized the list a bit differently, I see your point about that

Thanks. I only ran the lint command, but without a warning on my modifications, I thought it was correct, my mistake.

[shamoon]

Nothing major but did need a lint and I enforced a minimum refresh (we like to do this to maybe avoid people DDoSing themselves)

Also, I dont disagree with the checking of the refreshInterval param, but since we dont do it anywhere I made it consistent

In general, this works well and I do see the value in it.

Let me know if you have any concerns, thanks for the PR

[ni0ki]

Nothing major but did need a lint and I enforced a minimum refresh (we like to do this to maybe avoid people DDoSing themselves)

Also, I dont disagree with the checking of the refreshInterval param, but since we dont do it anywhere I made it consistent

Fine by me. Enforcing a minimum interval is a good idea. I'll follow your decision about checking refreshInterval.

Everything is good on my side, thanks for the adjustements!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.