Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fields not working for healthchecks widget #2440

Merged

Conversation

lawtonmanning
Copy link
Contributor

Proposed change

If the fields key is defined for the healthchecks widget, no fields will show due to the field labels being translated manually on the Block component's label prop.

Before (fields not set in YAML):
before-no-fields

Before (fields: ["status"] set in YAML):
before-fields

After (fields: ["status"] set in YAML):
after

Closes # N/A

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@lawtonmanning
Copy link
Contributor Author

There might be a similar bug in the strelaysrv widget here but I haven't tested it locally. https://github.com/gethomepage/homepage/blob/main/src/widgets/strelaysrv/component.jsx#L32

@shamoon shamoon enabled auto-merge (squash) December 7, 2023 04:52
@shamoon shamoon changed the title Fix fields key on healthchecks widget Fix: fields not working for healthchecks widget Dec 7, 2023
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yea shouldn’t be like that

@shamoon shamoon merged commit 914cd71 into gethomepage:main Dec 7, 2023
2 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Dec 10, 2023
…0.8.3@4214f13 (#15946)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.2` -> `v0.8.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.3`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.3)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.2...v0.8.3)

#### What's Changed

- Feature: Fritz!Box Widget by
[@&#8203;evorg](https://togithub.com/evorg) in
[gethomepage/homepage#2387
- Change: changedetection.io widget count diff if not viewed by
[@&#8203;xconverge](https://togithub.com/xconverge) in
[gethomepage/homepage#2401
- Chore: migrate crowdin to GHA by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2421
- Enhancement: improve fritzbox proxy perfomance by
[@&#8203;evorg](https://togithub.com/evorg) in
[gethomepage/homepage#2429
- Feature: setting for equal height cards by
[@&#8203;jdcmarques](https://togithub.com/jdcmarques) in
[gethomepage/homepage#2432
- Fix: fields not working for healthchecks widget by
[@&#8203;lawtonmanning](https://togithub.com/lawtonmanning) in
[gethomepage/homepage#2440
- Fix: Increase kubernetes cpu/mem usage scale by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2453

#### New Contributors

- [@&#8203;evorg](https://togithub.com/evorg) made their first
contribution in
[gethomepage/homepage#2387
- [@&#8203;xconverge](https://togithub.com/xconverge) made their first
contribution in
[gethomepage/homepage#2401
- [@&#8203;jdcmarques](https://togithub.com/jdcmarques) made their first
contribution in
[gethomepage/homepage#2432
- [@&#8203;lawtonmanning](https://togithub.com/lawtonmanning) made their
first contribution in
[gethomepage/homepage#2440

**Full Changelog**:
gethomepage/homepage@v0.8.2...v0.8.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44OS41IiwidXBkYXRlZEluVmVyIjoiMzcuODkuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants