-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: fields not working for healthchecks widget #2440
Fix: fields not working for healthchecks widget #2440
Conversation
There might be a similar bug in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks yea shouldn’t be like that
…0.8.3@4214f13 (#15946) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.2` -> `v0.8.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.3`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.3) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.2...v0.8.3) #### What's Changed - Feature: Fritz!Box Widget by [@​evorg](https://togithub.com/evorg) in [gethomepage/homepage#2387 - Change: changedetection.io widget count diff if not viewed by [@​xconverge](https://togithub.com/xconverge) in [gethomepage/homepage#2401 - Chore: migrate crowdin to GHA by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2421 - Enhancement: improve fritzbox proxy perfomance by [@​evorg](https://togithub.com/evorg) in [gethomepage/homepage#2429 - Feature: setting for equal height cards by [@​jdcmarques](https://togithub.com/jdcmarques) in [gethomepage/homepage#2432 - Fix: fields not working for healthchecks widget by [@​lawtonmanning](https://togithub.com/lawtonmanning) in [gethomepage/homepage#2440 - Fix: Increase kubernetes cpu/mem usage scale by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2453 #### New Contributors - [@​evorg](https://togithub.com/evorg) made their first contribution in [gethomepage/homepage#2387 - [@​xconverge](https://togithub.com/xconverge) made their first contribution in [gethomepage/homepage#2401 - [@​jdcmarques](https://togithub.com/jdcmarques) made their first contribution in [gethomepage/homepage#2432 - [@​lawtonmanning](https://togithub.com/lawtonmanning) made their first contribution in [gethomepage/homepage#2440 **Full Changelog**: gethomepage/homepage@v0.8.2...v0.8.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44OS41IiwidXBkYXRlZEluVmVyIjoiMzcuODkuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
If the
fields
key is defined for thehealthchecks
widget, no fields will show due to the field labels being translated manually on theBlock
component'slabel
prop.Before (fields not set in YAML):
![before-no-fields](https://private-user-images.githubusercontent.com/27016794/288626334-6033582f-b39c-40ad-a0c4-9d8e17bb0b68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3OTM1NzUsIm5iZiI6MTcxOTc5MzI3NSwicGF0aCI6Ii8yNzAxNjc5NC8yODg2MjYzMzQtNjAzMzU4MmYtYjM5Yy00MGFkLWEwYzQtOWQ4ZTE3YmIwYjY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDAwMjExNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3NTE0ZDU4YWExMjA1NDMwZWM3NmE3NWJmZWJkZjU3N2Q0NjkyYThhMWRhY2FlN2ExYTE4Y2M2YTkwNjFiYzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.RyXyfqpFBcx2kWtoRD_Ofcj92_NIog1c3FTulA6c2rw)
Before (fields: ["status"] set in YAML):
![before-fields](https://private-user-images.githubusercontent.com/27016794/288626300-0260e5e8-5743-4f3b-a3c1-f144d7ef1d4f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3OTM1NzUsIm5iZiI6MTcxOTc5MzI3NSwicGF0aCI6Ii8yNzAxNjc5NC8yODg2MjYzMDAtMDI2MGU1ZTgtNTc0My00ZjNiLWEzYzEtZjE0NGQ3ZWYxZDRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDAwMjExNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0MGY5OWNhMjcwOWRkYjgwNGE3ZTA3NDQxNDU3M2FlMzIxM2Y5MWI2ODY4OWQ5ZTBjNDhkMmVmNTAxNDMyOTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.oqgaxyD7kwh1pxUbg4aolCajTFwmJQzwCRiTBYpN9nA)
After (fields: ["status"] set in YAML):
![after](https://private-user-images.githubusercontent.com/27016794/288626383-8bd7124f-25fb-4df1-b10b-5ea12742c12e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3OTM1NzUsIm5iZiI6MTcxOTc5MzI3NSwicGF0aCI6Ii8yNzAxNjc5NC8yODg2MjYzODMtOGJkNzEyNGYtMjVmYi00ZGYxLWIxMGItNWVhMTI3NDJjMTJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDAwMjExNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE5ZTRjYzIzYjhhZTczZDcxMDVhNDMxNmJhNjMxNGQ0N2Y4YTBmYmQ2MmQ2NmYxODc2OTdiZjViOGMzNDc4YWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nGYmweB0XcElHkt58aXyaXUDL_-z0VJ5g588gPDA9aY)
Closes # N/A
Type of change
Checklist: