Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify a timezone for events #2623

Merged
merged 2 commits into from Jan 15, 2024
Merged

Conversation

denispapec
Copy link
Contributor

Proposed change

New timezone option forces the events to use a specific timezone when provided calendar file is missing that information.

Closes #2575

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's certainly not your fault but this code has become extremely hard to parse. Im fine basically assuming this works...

docs/widgets/services/calendar.md Outdated Show resolved Hide resolved
src/widgets/calendar/event.jsx Outdated Show resolved Hide resolved
@denispapec
Copy link
Contributor Author

It's certainly not your fault but this code has become extremely hard to parse. Im fine basically assuming this works...

Yeah, I agree. Seems to be working with replicated issues.

@shamoon shamoon enabled auto-merge (squash) January 15, 2024 02:00
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers thanks as always

@shamoon shamoon merged commit 1f2081a into gethomepage:main Jan 15, 2024
5 checks passed
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
@denispapec denispapec deleted the 2575 branch May 5, 2024 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants