Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Romm Widget #2663

Merged
merged 9 commits into from Jan 20, 2024
Merged

Feature: Romm Widget #2663

merged 9 commits into from Jan 20, 2024

Conversation

karl0ss
Copy link
Contributor

@karl0ss karl0ss commented Jan 17, 2024

Proposed change

Add Romm service widget

Closes #2550

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon changed the title changes to add romm Feature: Romm Widget Jan 17, 2024
@shamoon
Copy link
Collaborator

shamoon commented Jan 18, 2024

@karl0ss are you able to address the lint errors (you checked the box but didnt do that I think), documentation and merge conflict?

@karl0ss
Copy link
Contributor Author

karl0ss commented Jan 18, 2024

I will, but am busy this week, I couldn't get the docs to install, haven't retired since your last push, but yeah I can fix the issues and will open the pr as non draft, I'll see if I get some time tomorrow to do it.

@shamoon shamoon marked this pull request as ready for review January 20, 2024 07:35
@shamoon shamoon enabled auto-merge (squash) January 20, 2024 07:35
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-19 at 11 32 24 PM

@shamoon shamoon merged commit f6ca3f5 into gethomepage:main Jan 20, 2024
5 checks passed
@karl0ss
Copy link
Contributor Author

karl0ss commented Jan 20, 2024

Thanks for your help on this, I am having a nightmare trying to get pre-commit running....just to mention, this will need slight updating as if you are using auth in romm you need this in your services.yaml

 - Rom Manager:
    icon: romm
    href: <URL>
    widget:
      type: romm
      url: <URL>
      username: <Username>
      password: <Password>

@shamoon
Copy link
Collaborator

shamoon commented Jan 20, 2024

Ah. What type of auth does the romm api use? I didnt look for too long but I didnt see docs

@gantoine
Copy link
Contributor

gantoine commented Jan 20, 2024

Requests can be made to protected API endpoints with an authorization header. The token is the base64 encoded value of username:password. Example using cURL: curl https://romm.local/api/platforms -H 'Authorization: Basic YWRtaW46aHVudGVyMg=='

I can open a PR with support for auth in a couple hours.

@shamoon
Copy link
Collaborator

shamoon commented Jan 20, 2024

Great thanks. That should work "out of the box" already

@karl0ss
Copy link
Contributor Author

karl0ss commented Jan 20, 2024

Yeah they work out the box via the standard proxy im running with auth -
image

discretizer pushed a commit to discretizer/homepage that referenced this pull request Jan 28, 2024
---------

Co-authored-by: Karl Hudgell <karl.hudgell@bjss.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
discretizer pushed a commit to discretizer/homepage that referenced this pull request Feb 6, 2024
---------

Co-authored-by: Karl Hudgell <karl.hudgell@bjss.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
discretizer pushed a commit to discretizer/homepage that referenced this pull request Feb 6, 2024
---------

Co-authored-by: Karl Hudgell <karl.hudgell@bjss.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants