-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Romm Widget #2663
Feature: Romm Widget #2663
Conversation
@karl0ss are you able to address the lint errors (you checked the box but didnt do that I think), documentation and merge conflict? |
I will, but am busy this week, I couldn't get the docs to install, haven't retired since your last push, but yeah I can fix the issues and will open the pr as non draft, I'll see if I get some time tomorrow to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help on this, I am having a nightmare trying to get pre-commit running....just to mention, this will need slight updating as if you are using auth in romm you need this in your services.yaml
|
Ah. What type of auth does the romm api use? I didnt look for too long but I didnt see docs |
Requests can be made to protected API endpoints with an authorization header. The token is the base64 encoded value of I can open a PR with support for auth in a couple hours. |
Great thanks. That should work "out of the box" already |
--------- Co-authored-by: Karl Hudgell <karl.hudgell@bjss.com> Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
--------- Co-authored-by: Karl Hudgell <karl.hudgell@bjss.com> Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
--------- Co-authored-by: Karl Hudgell <karl.hudgell@bjss.com> Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
Proposed change
Add Romm service widget
Closes #2550
Type of change
Checklist: