Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: iCal integration use event data hash instead of unstable uid #2758

Merged
merged 1 commit into from Jan 26, 2024
Merged

Fix: iCal integration use event data hash instead of unstable uid #2758

merged 1 commit into from Jan 26, 2024

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Jan 26, 2024

Proposed change

Im not certain if the calendar in the linked issue is improperly implementing the calendar spec (I'd guess so) but in that case the uid is not stable between pulls of the calendar. See diffs from pulling the calendar even seconds apart:

Apparently this is not so uncommon https://stackoverflow.com/questions/38193837/how-to-handle-a-uid-of-an-ics-calednar-that-will-change-every-time-i-access-it

Solution is to hash the start/end/title & a couple other things. I tested with a few calendars out there including recurrence but as we've seen, calendars are messy...

Screenshot 2024-01-26 at 12 49 19 AM Screenshot 2024-01-26 at 12 59 21 AM Screenshot 2024-01-26 at 1 05 00 AM

Closes #2753

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon merged commit 99e1e3d into main Jan 26, 2024
2 checks passed
@shamoon shamoon deleted the fix/2753 branch January 26, 2024 09:14
discretizer pushed a commit to discretizer/homepage that referenced this pull request Jan 28, 2024
@discretizer
Fix: iCal integration use event data hash instead of uid (gethomepage…
afed944 
…#2758)
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jan 29, 2024
@truecharts-admin
chore(deps): update container image ghcr.io/gethomepage/homepage to v…
d52c6a2 
…0.8.7@06203a4 by renovate (#17670)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.6` -> `v0.8.7` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.7`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.7)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.6...v0.8.7)

#### What's Changed

- Feature: Added gatus uptime widget by
[@&#8203;Nedra1998](https://togithub.com/Nedra1998) in
[gethomepage/homepage#2729
- Fix: iCal integration use event data hash instead of unstable uid by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2758
- Enhancement: extend hdhomerun widget by
[@&#8203;JeffRandall](https://togithub.com/JeffRandall) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2757

#### New Contributors

- [@&#8203;Nedra1998](https://togithub.com/Nedra1998) made their first
contribution in
[gethomepage/homepage#2729
- [@&#8203;JeffRandall](https://togithub.com/JeffRandall) made their
first contribution in
[gethomepage/homepage#2757

**Full Changelog**:
gethomepage/homepage@v0.8.6...v0.8.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
discretizer pushed a commit to discretizer/charts that referenced this pull request Jan 29, 2024
@truecharts-admin @discretizer
chore(deps): update container image ghcr.io/gethomepage/homepage to v…
1a4e828 
…0.8.7@06203a4 by renovate (truecharts#17670)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.6` -> `v0.8.7` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

[`v0.8.7`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.7)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.6...v0.8.7)

- Feature: Added gatus uptime widget by
[@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) in
[gethomepage/homepage#2729
- Fix: iCal integration use event data hash instead of unstable uid by
[@&truecharts#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2758
- Enhancement: extend hdhomerun widget by
[@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) and
[@&truecharts#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2757

- [@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) made their first
contribution in
[gethomepage/homepage#2729
- [@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) made their
first contribution in
[gethomepage/homepage#2757

**Full Changelog**:
gethomepage/homepage@v0.8.6...v0.8.7

</details>

---

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
GabrielBarzen pushed a commit to GabrielBarzen/charts that referenced this pull request Feb 2, 2024
@truecharts-admin
chore(deps): update container image ghcr.io/gethomepage/homepage to v…
606243a 
…0.8.7@06203a4 by renovate (truecharts#17670)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.6` -> `v0.8.7` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.7`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.7)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.6...v0.8.7)

#### What's Changed

- Feature: Added gatus uptime widget by
[@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) in
[gethomepage/homepage#2729
- Fix: iCal integration use event data hash instead of unstable uid by
[@&truecharts#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2758
- Enhancement: extend hdhomerun widget by
[@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) and
[@&truecharts#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2757

#### New Contributors

- [@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) made their first
contribution in
[gethomepage/homepage#2729
- [@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) made their
first contribution in
[gethomepage/homepage#2757

**Full Changelog**:
gethomepage/homepage@v0.8.6...v0.8.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
discretizer pushed a commit to discretizer/homepage that referenced this pull request Feb 6, 2024
@discretizer
Fix: iCal integration use event data hash instead of uid (gethomepage…
cf92922 
…#2758)
discretizer pushed a commit to discretizer/homepage that referenced this pull request Feb 6, 2024
@discretizer
Fix: iCal integration use event data hash instead of uid (gethomepage…
8b2bedd 
…#2758)
Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024
@shamoon @Plancke
Fix: iCal integration use event data hash instead of uid (gethomepage…
a5dca12 
…#2758)
Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024
@shamoon @Plancke
Fix: iCal integration use event data hash instead of uid (gethomepage…
5564810 
…#2758)
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] ical Calendar widgets multiplies events
1 participant
@shamoon