Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: iCal integration fails with all-day events #2883

Merged
merged 4 commits into from Feb 10, 2024

Conversation

sasagar
Copy link
Contributor

@sasagar sasagar commented Feb 10, 2024

Proposed change

This PR fixes a issue of iCal integration.

For the one-day event with Google Calendar, the dtend would not defined. So the error appeared.
This PR fixes about it: when dtend is not defined, set it as same as dtstart.

And also, if dtend and dtstart are the same, set duration to 1;

Closes #2882

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon linked an issue Feb 10, 2024 that may be closed by this pull request
@shamoon
Copy link
Collaborator

shamoon commented Feb 10, 2024

Thanks, I already had a fix for this as someone reported it earlier, so I've just merged that in here instead of closing this PR. I think it's simpler. Please let me know your thoughts

@shamoon shamoon changed the title fix: got error when the end date/time is not defined within iCal integration. Fix: iCal integration fails with all-day events Feb 10, 2024
@shamoon shamoon enabled auto-merge (squash) February 10, 2024 20:10
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, well let me know if you have any concerns. Thanks again.

Screenshot 2024-02-10 at 12 22 29 PM

@shamoon shamoon merged commit 1c529c0 into gethomepage:main Feb 10, 2024
2 checks passed
Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024
---------

Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024
---------

Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] iCal Integration with all-day events
2 participants