Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: use Script component instead of async script for custom.js #2901

Merged
merged 1 commit into from Feb 14, 2024
Merged

Change: use Script component instead of async script for custom.js #2901

merged 1 commit into from Feb 14, 2024

Conversation

Cyberbeni
Copy link
Contributor

@Cyberbeni Cyberbeni commented Feb 13, 2024 •
edited

Proposed change

Closes #2900

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon changed the title Use Script component instead of async script Change: use Script component instead of async script for custom.js Feb 14, 2024
@shamoon
Copy link
Collaborator

shamoon commented Feb 14, 2024

Well great, does seem to work for me, thats great. Did you test the docker image as well?

I suppose theres the chance this affects existing users in unexpected ways, at worst seems like the script will run later than previously.

@shamoon shamoon enabled auto-merge (squash) February 14, 2024 00:28
@Cyberbeni
Copy link
Contributor Author

Yes, I tested it by building the docker image locally.

shamoon
shamoon approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, yea me too. This will sit in main for a while until our next release, we'll see if anything comes up. Not sure how we didnt try this before...

Thanks for the PR

@shamoon shamoon merged commit ea03105 into gethomepage:main Feb 14, 2024
2 checks passed
Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024
@Cyberbeni @Plancke
Change: use Script component instead of async script for custom.js (g…
25d62b3 
…ethomepage#2901)
Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024
@Cyberbeni @Plancke
Change: use Script component instead of async script for custom.js (g…
806836d 
…ethomepage#2901)
truecharts-admin added a commit to truecharts/charts that referenced this pull request Mar 11, 2024
@truecharts-admin
chore(deps): update container image ghcr.io/gethomepage/homepage to v…
7ba5853 
…0.8.9@869c800 by renovate (#19065)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.8` -> `v0.8.9` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.9`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.9)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.8...v0.8.9)

#### What's Changed

- Feature: Add list view for custom api by
[@&#8203;sgrtye](https://togithub.com/sgrtye) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2891
- Change: use Script component instead of async script for custom.js by
[@&#8203;Cyberbeni](https://togithub.com/Cyberbeni) in
[gethomepage/homepage#2901
- Change: move custom.css linking to head to avoid FOUC by
[@&#8203;Cyberbeni](https://togithub.com/Cyberbeni) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2916
- Enhancement: Add enablePools option to TrueNAS service widget by
[@&#8203;dstotz](https://togithub.com/dstotz) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2908
- Enhancement: Add requestBody as option for customapi widget by
[@&#8203;dstotz](https://togithub.com/dstotz) in
[gethomepage/homepage#2921
- Enhancement: allow api auth with moonraker service by
[@&#8203;stevendejongnl](https://togithub.com/stevendejongnl) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2934
- Add Plant-it widget by
[@&#8203;MDeLuise](https://togithub.com/MDeLuise) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#2941
- Chore(deps): Bump systeminformation from 5.21.24 to 5.22.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#2999
- Chore(deps-dev): Bump eslint from 8.56.0 to 8.57.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3000
- Chore(deps-dev): Bump postcss from 8.4.33 to 8.4.35 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3001
- Chore(deps): Bump recharts from 2.11.0 to 2.12.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3002
- Fix: support cyrillic characters in quicklaunch by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3020
- Fix: docker status labels colors by
[@&#8203;RoboMagus](https://togithub.com/RoboMagus) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3028
- Enhancement: Add formatting options to weather widgets by
[@&#8203;benphelps](https://togithub.com/benphelps) in
[gethomepage/homepage#3093
- Feature: Add Homebox widget by
[@&#8203;cadeluca](https://togithub.com/cadeluca) in
[gethomepage/homepage#3095

#### New Contributors

- [@&#8203;Cyberbeni](https://togithub.com/Cyberbeni) made their first
contribution in
[gethomepage/homepage#2901
- [@&#8203;dstotz](https://togithub.com/dstotz) made their first
contribution in
[gethomepage/homepage#2908
- [@&#8203;stevendejongnl](https://togithub.com/stevendejongnl) made
their first contribution in
[gethomepage/homepage#2934
- [@&#8203;MDeLuise](https://togithub.com/MDeLuise) made their first
contribution in
[gethomepage/homepage#2941
- [@&#8203;cadeluca](https://togithub.com/cadeluca) made their first
contribution in
[gethomepage/homepage#3095

**Full Changelog**:
gethomepage/homepage@v0.8.8...v0.8.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cyberbeni @shamoon