Fix: log error when getting services from Docker server fails #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not raising an error when a server fails to get services from Docker could lead to confusion when the server does not appear to be functioning correctly. This commit adds an error log when a server fails to get services from Docker.
|
See the Discord discussion for details. TLDR: My homepage failed to resolve any Docker services. After some debugging I found out that a silent error was thrown, because homepage couldn't access the secrets.
|
shamoon
approved these changes
Mar 20, 2024
shamoon
changed the title
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Mar 24, 2024
…0.8.10@fc0d6e8 by renovate (#19733) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.9` -> `v0.8.10` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.10`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.10) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.9...v0.8.10) #### What's Changed - Fix: field parsing can fail with docker labels by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3101 - Fix: Add alternative 'offline' status to EspHome widget by [@​RoboMagus](https://togithub.com/RoboMagus) in [gethomepage/homepage#3107 - Fix: log error when getting services from Docker server fails by [@​she11sh0cked](https://togithub.com/she11sh0cked) in [gethomepage/homepage#3147 - Fix: Glances cpu & info widgets information by [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3164 - Enhancement: support Jackett widget with admin password by [@​technowhizz](https://togithub.com/technowhizz) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3165 - Fix: correctly handle direct tab navigation with encoded chars by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3172 #### New Contributors - [@​she11sh0cked](https://togithub.com/she11sh0cked) made their first contribution in [gethomepage/homepage#3147 - [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) made their first contribution in [gethomepage/homepage#3164 - [@​technowhizz](https://togithub.com/technowhizz) made their first contribution in [gethomepage/homepage#3165 **Full Changelog**: gethomepage/homepage@v0.8.9...v0.8.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Apr 6, 2024
…v0.8.10 ) (#3396) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.9` -> `v0.8.10` | --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.10`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.10) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.9...v0.8.10) #### What's Changed - Fix: field parsing can fail with docker labels by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3101 - Fix: Add alternative 'offline' status to EspHome widget by [@​RoboMagus](https://togithub.com/RoboMagus) in [gethomepage/homepage#3107 - Fix: log error when getting services from Docker server fails by [@​she11sh0cked](https://togithub.com/she11sh0cked) in [gethomepage/homepage#3147 - Fix: Glances cpu & info widgets information by [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3164 - Enhancement: support Jackett widget with admin password by [@​technowhizz](https://togithub.com/technowhizz) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3165 - Fix: correctly handle direct tab navigation with encoded chars by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3172 #### New Contributors - [@​she11sh0cked](https://togithub.com/she11sh0cked) made their first contribution in [gethomepage/homepage#3147 - [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) made their first contribution in [gethomepage/homepage#3164 - [@​technowhizz](https://togithub.com/technowhizz) made their first contribution in [gethomepage/homepage#3165 **Full Changelog**: gethomepage/homepage@v0.8.9...v0.8.10 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI4MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Apr 6, 2024
…v0.8.10 ) (#3396) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.9` -> `v0.8.10` | --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.10`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.10) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.9...v0.8.10) #### What's Changed - Fix: field parsing can fail with docker labels by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3101 - Fix: Add alternative 'offline' status to EspHome widget by [@​RoboMagus](https://togithub.com/RoboMagus) in [gethomepage/homepage#3107 - Fix: log error when getting services from Docker server fails by [@​she11sh0cked](https://togithub.com/she11sh0cked) in [gethomepage/homepage#3147 - Fix: Glances cpu & info widgets information by [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3164 - Enhancement: support Jackett widget with admin password by [@​technowhizz](https://togithub.com/technowhizz) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3165 - Fix: correctly handle direct tab navigation with encoded chars by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3172 #### New Contributors - [@​she11sh0cked](https://togithub.com/she11sh0cked) made their first contribution in [gethomepage/homepage#3147 - [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) made their first contribution in [gethomepage/homepage#3164 - [@​technowhizz](https://togithub.com/technowhizz) made their first contribution in [gethomepage/homepage#3165 **Full Changelog**: gethomepage/homepage@v0.8.9...v0.8.10 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI4MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Apr 6, 2024
…v0.8.10 ) (#3396) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.9` -> `v0.8.10` | --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.10`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.10) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.9...v0.8.10) #### What's Changed - Fix: field parsing can fail with docker labels by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3101 - Fix: Add alternative 'offline' status to EspHome widget by [@​RoboMagus](https://togithub.com/RoboMagus) in [gethomepage/homepage#3107 - Fix: log error when getting services from Docker server fails by [@​she11sh0cked](https://togithub.com/she11sh0cked) in [gethomepage/homepage#3147 - Fix: Glances cpu & info widgets information by [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3164 - Enhancement: support Jackett widget with admin password by [@​technowhizz](https://togithub.com/technowhizz) and [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3165 - Fix: correctly handle direct tab navigation with encoded chars by [@​shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#3172 #### New Contributors - [@​she11sh0cked](https://togithub.com/she11sh0cked) made their first contribution in [gethomepage/homepage#3147 - [@​sunnycloudy1337](https://togithub.com/sunnycloudy1337) made their first contribution in [gethomepage/homepage#3164 - [@​technowhizz](https://togithub.com/technowhizz) made their first contribution in [gethomepage/homepage#3165 **Full Changelog**: gethomepage/homepage@v0.8.9...v0.8.10 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI4MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR addresses an issue where a server fails to retrieve services from Docker without raising an error, potentially causing confusion regarding server functionality. The fix adds an error log to provide clarity in such scenarios.
Type of change
Checklist: