Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions thrown by do-request are not catched anywhere #2

Closed
iarenaza opened this issue May 24, 2019 · 0 comments
Closed

Exceptions thrown by do-request are not catched anywhere #2

iarenaza opened this issue May 24, 2019 · 0 comments

Comments

@iarenaza
Copy link
Contributor

do-request can throw exceptions when there is an error performing the request, or when we get an invalid JSON value as a response for the request.

But we don't catch and manage those exceptions anywhere, and produce suitable return codes. Or alternatively, we don't document that they can throw exceptions and the caller is supposed to handle those exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant