You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Some of our re-frame event handler are impure according to the guidelines mentioned here and there. A good example of those antipatterns is this line [1] and this handler [2]
Keep in mind that those two examples are... well, just examples. The scope of this issue covers also seeking for other occurrences of the said antipatterns.
[1] - here a coeffect should be used
[2] - here we should probably write an fx (effect) that would create a js/Keycloak object and doto all the methods like .init, .error etc.
The text was updated successfully, but these errors were encountered:
Some of our re-frame event handler are impure according to the guidelines mentioned here and there. A good example of those antipatterns is this line [1] and this handler [2]
Keep in mind that those two examples are... well, just examples. The scope of this issue covers also seeking for other occurrences of the said antipatterns.
[1] - here a coeffect should be used
[2] - here we should probably write an
fx
(effect) that would create ajs/Keycloak
object anddoto
all the methods like.init
,.error
etc.The text was updated successfully, but these errors were encountered: