Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Purify re-frame handlers #15

Closed
werenall opened this issue Aug 19, 2019 · 0 comments
Closed

Purify re-frame handlers #15

werenall opened this issue Aug 19, 2019 · 0 comments

Comments

@werenall
Copy link
Contributor

werenall commented Aug 19, 2019

Some of our re-frame event handler are impure according to the guidelines mentioned here and there. A good example of those antipatterns is this line [1] and this handler [2]

Keep in mind that those two examples are... well, just examples. The scope of this issue covers also seeking for other occurrences of the said antipatterns.

[1] - here a coeffect should be used
[2] - here we should probably write an fx (effect) that would create a js/Keycloak object and doto all the methods like .init, .error etc.

werenall pushed a commit that referenced this issue Nov 23, 2020
[Re #15][Re #21]
This solves the problem of an auth token not being refreshed.
werenall pushed a commit that referenced this issue Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant