Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price API and Invoice Items API #15

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jramosg
Copy link
Contributor

@jramosg jramosg commented Mar 17, 2024

No description provided.

@bgalartza
Copy link
Contributor

Hello!
Thank you for adding the tests and squashing the commits.

For some reason the pipelines are not running for the pull requests (we need to give that a look), and we didn't realize that there is a mistake in the code (or maybe you forgot to commit that part):

The new dev.gethop.payments.stripe.price and dev.gethop.payments.stripe.invoice-items namespaces have to be required in the dev.gethop.payments.stripe namespace. This is required for the protocol to be extended correctly.

Once that is fixed we can accept and merge the commit.

Thank you again

Leaving the previous PR here for reference

@bgalartza bgalartza added the enhancement New feature or request label Mar 20, 2024
@jramosg
Copy link
Contributor Author

jramosg commented Mar 21, 2024

Hello @bgalartza,

You are right, I already added the namespaces in a new commit. Do you again need to squash both commits in one?

Thank you

@bgalartza
Copy link
Contributor

Yes, please.

Bear in mind that you don't need to open a new pull request if you don't want to. You can just git push --force in your repo/branch and the PR will be updated automatically.

@jramosg jramosg force-pushed the price+invoice-item-apis branch 5 times, most recently from aa5221a to 9382482 Compare March 21, 2024 11:23
invoice item api

cljfmt

protocol name

fix response path and refactor url-fn

price api and tests for price and invoice items

require namespaces
@jramosg
Copy link
Contributor Author

jramosg commented Mar 21, 2024

done!

@bgalartza bgalartza merged commit f143a74 into gethop-dev:master Mar 21, 2024
@bgalartza
Copy link
Contributor

Great!
Thank you for your time and work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants