Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds no wrap for reading time #88

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Adds no wrap for reading time #88

merged 1 commit into from
Mar 1, 2024

Conversation

jollydodo
Copy link
Contributor

@jollydodo jollydodo commented Jan 14, 2024

Reading time used to wrap to a new row, thereby distancing the reading time icon from the duration

Summary

I used the default Bootstrap 'text-nowrap' class to make sure that the reading time doesn't wrap to the next line without the icon. I checked this with all window sizes and it seems to work well in Chrome and Safari.

Basic example

new:
Scherm­afbeelding 2024-01-14 om 21 41 02

old:
Scherm­afbeelding 2024-01-14 om 21 40 43

Motivation

The old method looked a bit ugly on certain screen sizes (especially mobile and with multiple authors). I also changed the margin-left from reading-time to 1rem, because I think the default is a bit too much. That's why my screenshot might look a little bit different. Nevertheless, I believe that the icon should always be on the same line as the duration.

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

Reading time used to wrap to a new row, thereby distancing the reading time icon from the duration
@h-enk h-enk changed the title no wrap for reading time Adds no wrap for reading time Mar 1, 2024
@h-enk h-enk merged commit d03344f into gethyas:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants