Add Java port

[pradyunsg]

Part of #23

Any chance of someone running 👀 through this?

[getify]

Is it appropriate for the tests to be in the same file as the implementation? This seems strange to me.

[pradyunsg]

I agree. I'm not very fluent in Java (and I'd presume neither are you). So, any ideas?

[pradyunsg]

Also, shouldn't the README.md be modified to add instructions for running tests?

(editted)

[getify]

shouldn't the README.md be modified?

Yes, see the modifications I made to the README.md in the "javascript", "node" and "php" branches as minimal required updates for each port.

[pradyunsg]

But what should the modifications be?

EDIT: If we are moving the tests out, then the change will be different. So, we are moving the tests out, right? Let's address that first.

[getify]

As indicated in the PORTING.md, item (4), I'd prefer to see something that's consistent with each language's basic conventions. In general, I believe most languages keep implementation and tests separate. I can't think of a strong reason to combine those separate concerns in a single file for any language.

[pradyunsg]

I think I can split the Java file. I'll get to it later today or tomorrow.
Just that, what should the package name be? com.getify.json_minify is what I'm thinking...

PS: I should split the python tests as well. Right?

[getify]

Can we do com.json_minify? I dunno enough about Java to know if that's good or bad, but I don't see why this needs the getify moniker in it. I don't have any other Java software that anyone would need to namespace in.

I should split the python tests as well. Right?

Yes please. :)

[pradyunsg]

I guess we can.

Added to tomorrow's TODO list

[nrktkt]

If this is still unresolved... If the java repo is created, I can get this set up with maven and move the tests into appropriate locations with junit. If there is further interest we can get things set up on maven central or in jipack.

[pradyunsg]

@kag0

If this is still unresolved...

It is indeed unresolved.

If the java repo is created,

I'm assuming you mean the java branch on this repository, which is created.

I can get this set up with maven and move the tests into appropriate locations with junit.

Please do. I wanted to do this but don't really have that much knowledge (and now, time to gain it) to do this.

If there is further interest we can get things set up on maven central or in jipack.

I'm interested. 😄

---

Please do read PORTING.md and TESTING.md files. You'll should to make a PR to the java branch in this repository. You could include the work I've done (this PR) or start afresh off the java branch in the repository.

[nrktkt]

Sounds good. Let's merge this PR for now and open issues regarding creating an account and signing keys for maven central, and maybe one for CI/CD.

also, do you mind if I add some inline comments to this PR for improvements? (I'll do them all when I separate the tests if they aren't done before merging the PR)

[pradyunsg]

Sounds good. Let's merge this PR for now

Done.

open issues regarding creating an account and signing keys for maven central, and maybe one for CI/CD.

I'd prefer that you open those issues, you are the one with a better idea of what to do.

also, do you mind if I add some inline comments to this PR for improvements? (I'll do them all when I separate the tests if they aren't done before merging the PR)

No I don't. 😄

[nrktkt]

Make these strings private static final class variables.