Feature: useDeferred(...) #18
Conversation
…g context, adding .vscode to gitignore
| @@ -3,3 +3,4 @@ | |||
| node_modules/ | |||
| dist/ | |||
| coverage/ | |||
| .vscode/ | |||
There was a problem hiding this comment.
I normally have formatOnSave set to true, so for this repo specifically I set it to false. Didn't want to pollute it with my editor settings so I figured this would be the best course of action.
There was a problem hiding this comment.
I'd instead add stuff to your .git/info/exclude or a user-global alternative.
|
|
||
| function useDeferred() { | ||
| if (getCurrentBucket()) { | ||
| const [deferred] = useState((function () { |
There was a problem hiding this comment.
Critical Area: Would love some insight on other ways to generate a Deferred object as an initial value. an IIFE that creates one was the best that I could come up with.
There was a problem hiding this comment.
If you can do this without support form upstream, what's the value of this being included here? You're setting yourself up for a leaking batteries problem, no?
There was a problem hiding this comment.
I'm not sure I understand what you mean
There was a problem hiding this comment.
I don't understand the value in having this function implemented in this package. Can you help me understand why you see value in that?
There was a problem hiding this comment.
Derp, never mind me. Just realized that this was invited by getify on #17. I don't think it's wise to lump stuff together before there's good evidence for it being the default, but I also don't think it's wise to go against the maintainer's view.
Hello there,
Thanks for this awesome project. I'm not used to what's going on here, but I tried my best to emulate the style and rules that i've seen throughout the project so far.
this PR adds tests and implementation for
useDeferred. It returns a state-slotted object that contains a promise, along with its resolve and reject functions.Closes #17