Replace the "As mentioned earlier" part in ch1.md #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe I'm wrong (hope I'm not), I don't remember any mentions about an array type at that point of the book. I've tried to find it, but I found nothing. It might be an artefact of the original book (the 1st edition). So I'd replace the "As mentioned earlier" part with something not confusing. I'm not a native English, so probably you have a better idea for the replacement.
Lasitha92
reviewed
Jun 10, 2022
| @@ -123,7 +123,7 @@ You won't encounter direct usage of symbols very often in typical JS programs. T | |||
|
|
|||
| Besides primitives, the other value type in JS is an object value. | |||
|
|
|||
| As mentioned earlier, arrays are a special type of object that's comprised of an ordered and numerically indexed list of data: | |||
| It is worth mentioning that JS arrays are a special type of object that's comprised of an ordered and numerically indexed list of data: | |||
There was a problem hiding this comment.
It should be like this right?
special type of objects that comprised of an ordered and numerically ...
getify
force-pushed
the
2nd-ed
branch
5 times, most recently
from
23d8b7b
to
e909d38
Compare
getify
force-pushed
the
2nd-ed
branch
3 times, most recently
from
29c2978
to
667c741
Compare
getify
force-pushed
the
2nd-ed
branch
6 times, most recently
from
ec72a23
to
976d472
Compare
w3bdesign
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm wrong (hope I'm not), I don't remember any mentions about an array type at that point of the book. I've tried to find it, but I found nothing. It might be an artefact of the original book (the 1st edition).
So I'd replace the "As mentioned earlier" part with something not confusing. I'm not a native English, so probably you have a better idea for the replacement.
"I already searched for this issue"
Edition: 2nd
Book Title: You Don't Know JS Yet: Get Started
Chapter: 2
Section Title: Values
Topic: Arrays And Objects