Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

runner(..) plugin incorrectly checks yielded/returned values #27

Closed
getify opened this issue Feb 5, 2014 · 0 comments
Closed

runner(..) plugin incorrectly checks yielded/returned values #27

getify opened this issue Feb 5, 2014 · 0 comments
Assignees

Comments

@getify
Copy link
Owner

getify commented Feb 5, 2014

See this section of the runner(..) plugin code:

https://github.com/getify/asynquence/blob/master/contrib/plugin.runner.js#L57-L75

The check there incorrectly only looks ASQ.isSequence(..) and doesn't account for having an ASQ message-wrapper yielded/returned. Should also check for ASQ.isMessageWrapper() on the value.

Relies on #26 being fixed.

@ghost ghost assigned getify Feb 5, 2014
@getify getify closed this as completed in 205125f Feb 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant