Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

ASQ.isMessageWrapper(..) should check for actual array #26

Closed
getify opened this issue Feb 5, 2014 · 1 comment
Closed

ASQ.isMessageWrapper(..) should check for actual array #26

getify opened this issue Feb 5, 2014 · 1 comment
Assignees
@getify

Comments

@getify
Copy link
Owner

getify commented Feb 5, 2014

ASQ.isMessageWrapper(..) currently only checks for ASQ branding, which means it's incapable of distinguishing between an ASQ instance and a message wrapper. Should fix the check so that it looks for Array.isArray(..) to match the tested object as well.
@ghost ghost assigned getify Feb 5, 2014
@getify getify mentioned this issue Feb 5, 2014
Closed
@getify
Copy link
Owner Author

getify commented Feb 7, 2014

Also, ASQ.isSequence(..) gives a false positive on ASQ message wrappers. Should check to make sure branding matches but NOT an array.

@getify getify closed this as completed in 97e150a Feb 7, 2014
getify added a commit that referenced this issue Feb 7, 2014
@getify
contrib: patching test for 'runner(..)', makes sure we can close #27 …
205125f 
…now that #26 is fixed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@getify getify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getify