Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technical review - iennae@gmail.com #38

Closed
iennae opened this issue Jan 13, 2014 · 5 comments
Closed

technical review - iennae@gmail.com #38

iennae opened this issue Jan 13, 2014 · 5 comments
Assignees

Comments

@iennae
Copy link

iennae commented Jan 13, 2014

As per instructions starting a single issue for all of my comments on the book.

@iennae
Copy link
Author

iennae commented Jan 13, 2014

var a=2;

keeps getting called a program. This is jarring as while technically it could be it's more of an expression.

@iennae
Copy link
Author

iennae commented Jan 13, 2014

misleading "Engine: I need to LHS reference arg1. You dig?" as arg1 doesn't appear in the code snippet (although mentioned in the paragraph above.

@iennae
Copy link
Author

iennae commented Jan 13, 2014

We said that Scope is a set of rules for looking up variables by their identifier name. Sometimes, you will look up a variable, and it won't exist in the most immediate Scope you are currently executing in.

.. This is a confusing statement. For people who don't understand scope this doesn't seem enlightening. You've defined scope as "set of rules for looking up variables by their identifier name". You're hinting at the fact that scope is like an onion with layers but not explicit in definition.

@iennae
Copy link
Author

iennae commented Jan 13, 2014

Introducing "global scope" without mentioning it earlier on:

The RHS reference for b cannot be resolved inside the function foo, but it can be resolved in the Scope surrounding it (in this case, the global, but could just be another Nested Scope cousin!).

@getify
Copy link
Owner

getify commented Feb 8, 2014

Thanks for the great edit suggestions. Should be addressed now. :)

@getify getify closed this as completed Feb 8, 2014
@getify getify self-assigned this Feb 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants