Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint #56

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Add lint #56

wants to merge 6 commits into from

Conversation

swtwsk
Copy link
Contributor

@swtwsk swtwsk commented Feb 3, 2022


Keep in mind:

@swtwsk swtwsk force-pushed the add-lint branch 4 times, most recently from 4f176a2 to 1770e6a Compare February 7, 2022 16:04
@swtwsk swtwsk marked this pull request as draft February 7, 2022 16:18
@swtwsk
Copy link
Contributor Author

swtwsk commented Feb 7, 2022

Marked as draft for now, as there are problems with variables in SQLFluff. Added a comment to the issue in SQLFluff repo about that, hopefully it will get resolved soon.

@swtwsk swtwsk marked this pull request as ready for review April 15, 2022 15:24
@swtwsk swtwsk force-pushed the add-lint branch 2 times, most recently from 8d28367 to e835464 Compare April 19, 2022 09:23
Comment on lines -15 to +16
"copier==5.1.0",
# due to the 'regex' conflict between copier and sqlfluff:
"copier @ git+https://github.com/swtwsk/copier@regex-update",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove when copier is updated

@swtwsk swtwsk marked this pull request as draft April 29, 2022 13:29
@swtwsk
Copy link
Contributor Author

swtwsk commented Apr 29, 2022

The code for the dp lint command is present in this PR. However, it cannot be used yet because of arise of the dependency hell — SQLFluff uses newest version of the regex library (although for now, it does not specify it (just regex = *) so the incompatibility can be missed at the build time) while copier in the 5.1.0 version requires regex to be in 2020 version, causing SQLFluff to fail at runtime.

Right now in the PR we reference the private fork of the copier (https://github.com/swtwsk/copier/tree/regex-update) that has an updated reference. However, it is not a maintainable solution, hence the decision to stop working on dp lint for now. People responsible of copier are working on the new 6.0.0 version that will not have such an outdated dependency; on the other hand, it will be using Jinja2 > 3.0, which is unsupported by dbt for now. In order to introduce dp lint correctly, we shall wait for both dbt and copier updates that will eventually get compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant