[HTTP-43] - Remove Encoding format from HttpLookupTableSource #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swtwsk
approved these changes
Dec 21, 2022
| @@ -58,11 +55,6 @@ public DynamicTableSource createDynamicTableSource(Context context) { | |||
| LOOKUP_REQUEST_FORMAT.key() | |||
| ); | |||
|
|
|||
| EncodingFormat<SerializationSchema<RowData>> encodingFormat = | |||
| helper.discoverEncodingFormat(SerializationFormatFactory.class, | |||
| HttpLookupConnectorOptions.LOOKUP_REQUEST_FORMAT | |||
There was a problem hiding this comment.
Shouldn't we remove this constant as well?
There was a problem hiding this comment.
We do want to keep it. It is used in GenericJsonQueryCreatorFactory :)
We still want to have encodingFormat and LOOKUP_REQUEST_FORMAT but the problem is that it was a "zombie" reference here, a leftover from previous refactoring.
Signed-off-by: Krzysztof Chmielewski <krzysiek.chmielewski@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'HttpLookupTableSource' has unused reference to Encoding format. It is not needed, since concrete type of encoding format should be created by 'LookupQueryCreatorFactory' implementation.
This PR removes this reference.
Resolves #43
PR Checklist