HTTP-74 Add path parameter support #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OlivierZembri @AdrianVasiliu please could you review and see if this would meet your needs? |
src/main/java/com/getindata/connectors/http/internal/table/lookup/GetRequestFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nicely does the trick, thanks David.
I think it would be worth adding an entry for it under https://github.com/getindata/flink-http-connector/blob/c2f3e7bdc6b9d03bf3b807ac30a1302f026f82dc/CHANGELOG.md#unreleased.
davidradl
force-pushed
the
flink74
branch
2 times, most recently
from
0f982d0
to
e9b3e2c
Compare
AdrianVasiliu
approved these changes
Apr 2, 2024
OlivierZembri
approved these changes
Apr 2, 2024
|
@kristoffSC the submitters of this issue have approved this change, are you ok to merge please? |
2 tasks
grzegorz8
approved these changes
Apr 3, 2024
src/test/java/com/getindata/connectors/http/internal/table/lookup/LookupQueryInfoTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/getindata/connectors/http/internal/table/lookup/LookupQueryInfo.java
Show resolved
Hide resolved
grzegorz8
changed the title
grzegorz8
changed the title
|
@grzegorz8 I accidentally closed this - it is reopened with the changes you requested. |
Signed-off-by: David Radley <david_radley@uk.ibm.com>
OlivierZembri
pushed a commit
to OlivierZembri/flink-http-connector
that referenced
this pull request
Apr 3, 2024
Signed-off-by: David Radley <david_radley@uk.ibm.com>
OlivierZembri
pushed a commit
to OlivierZembri/flink-http-connector
that referenced
this pull request
Apr 3, 2024
Signed-off-by: David Radley <david_radley@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add path patameter support
Resolves #74
PR Checklist