Replace context hook with direct call #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
License Compliance is complaining and I think we can drop this one further on. The change looks good to me - well done. |
em-pe
approved these changes
Feb 17, 2022
AlekJaworski
pushed a commit
to AlekJaworski/kedro-kubeflow
that referenced
this pull request
May 16, 2022
* Replace context hook with direct call * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context providing hook (that can't be overwritten in the project) is replaced by a direct call to a specific TemplateLoader in the ContextHelper to use environmental variables.
Resolves #107 #72
PR Checklist