-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clean deleted responses task on startup, and add tests #1292
Merged
gschier
merged 5 commits into
Kong:develop
from
rickychandra:feature/clean-responses-task
Dec 5, 2018
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9902b66
Add clean deleted responses task on startup, and add tests
1e86b8d
Bump version
gschier c92cf3e
Add hookDatabaseInit() call to perform ops on DB startup
gschier 969b5c5
Refactor clean responses function to fetch all from db instead of bat…
0571ffe
Merge branch 'develop' into feature/clean-responses-task
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,6 +80,8 @@ export async function migrate(doc: Object) { | |
} | ||
|
||
export async function hookDatabaseInit() { | ||
await models.response.cleanDeletedResponses(); | ||
|
||
console.log('Init responses DB'); | ||
} | ||
|
||
|
@@ -236,3 +238,24 @@ function migrateBodyCompression(doc: Object) { | |
|
||
return doc; | ||
} | ||
|
||
export async function cleanDeletedResponses() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Beautiful. Super clean and simple now 👍 😄 |
||
const responsesDir = path.join(getDataDirectory(), 'responses'); | ||
mkdirp.sync(responsesDir); | ||
|
||
let files = fs.readdirSync(responsesDir); | ||
if (files.length === 0) { | ||
return; | ||
} | ||
|
||
let whitelistFiles = (await db.all(type)).map(res => { | ||
return res.bodyPath.slice(responsesDir.length + 1); | ||
}); | ||
|
||
for (let index = 0; index < files.length; index++) { | ||
if (whitelistFiles.indexOf(files[index]) === -1) { | ||
const bodyPath = path.join(responsesDir, files[index]); | ||
fs.unlinkSync(bodyPath); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on these tests 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is my first time working with Jest and mocking functions seems to have many gotchas, such as affecting other test suites. I spent a few hours debugging them 😆.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, it can be tricky sometimes for sure. I'm quite the fan of Jest though as far as JS test frameworks go 💯