Height of the query preview box is not constrained for longer query strings #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 To help make this a smooth process, please be sure you have first read the |
j-collier
changed the title
gschier
approved these changes
Apr 20, 2018
|
Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌 |
luizmariz
pushed a commit
to luizmariz/insomnia
that referenced
this pull request
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #869.
This is the most simple solution that does not have a negative impact on user experience in my test. With this simple CSS change the height of the query preview box appears as normal if empty and will automatically expand to fit the length of the query which is ideal for longer queries.
A more robust solution would allow the user to expand and shrink the box at will. However I don't feel that would be ideal for the user experience because it adds an extra moving part when the box can resize on it's own very easily and the container itself is scrollable.