Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with bootstrap #211

Closed
oligalma opened this issue Oct 9, 2014 · 9 comments
Closed

conflict with bootstrap #211

oligalma opened this issue Oct 9, 2014 · 9 comments

Comments

@oligalma
Copy link

oligalma commented Oct 9, 2014

Hi,
I'd like to inform you that there is a conflict between the k2 2.6.8 and the bootstrap 3.2.0: The images of the k2 items don't display. I've found that the problem is caused by the class="modal" of the links:

      <span class="itemImage">
        <a class="modal" rel="{handler: 'image'}" href="/media/k2/items/cache/9caa2793658f3cc387f216157300b1ce_XL.jpg" title="Click to preview image">
            <img src="/media/k2/items/cache/9caa2793658f3cc387f216157300b1ce_L.jpg" alt="trousers 2" style="width:600px; height:auto;" />
        </a>
      </span>

thanks for the attention,
Marc

@K2Joom
Copy link

K2Joom commented Oct 9, 2014

I have seen this too.
My fix is to add display:inline-block or block and position:inherit to all modal classes for different views, in the k2.css

Simon

@kavadas
Copy link
Contributor

kavadas commented Oct 9, 2014

We are aware of this issue. The "modal" class was used traditionally by Joomla! to add modals. I think that the fix by @K2Joom does solve the issue.

@kavadas
Copy link
Contributor

kavadas commented Jan 12, 2016

We need to wait for this. There is a related issue #246 .

@kricore
Copy link
Contributor

kricore commented Jan 13, 2016

My two cents here, since this modal is also used in the frontend editing panel, and this is the default modal of older Joomla! version (which are supported with this version), this needs to be solved in the template.

In the upcoming version where only Joomla! 3.x is supported the modal will be completely stripped.

@kricore
Copy link
Contributor

kricore commented Mar 9, 2016

MooTools will be completely dropped so this issue will be resolved.

@kricore kricore closed this as completed Mar 9, 2016
@kavadas kavadas reopened this Mar 9, 2016
@kavadas
Copy link
Contributor

kavadas commented Mar 9, 2016

@kricore This has nothing to do with Mootools. It's the "modal" class name that conflicts with Bootstrap styles.

@kricore
Copy link
Contributor

kricore commented Mar 9, 2016

Since mootools will be removed and a new lightbox engine will be used, the
CSS class will also be changed, thus resolving this issue.

On Wed, Mar 9, 2016 at 6:00 PM, Lefteris Kavadas notifications@github.com
wrote:

@kricore https://github.com/kricore This has nothing to do with
Mootools. It's the "modal" class name that conflicts with Bootstrap styles.


Reply to this email directly or view it on GitHub
#211 (comment).

@kavadas
Copy link
Contributor

kavadas commented Mar 10, 2016

@kricore

No, that's not the case. The class name will probably maintained for backwards compatibility, for people that are using overrides.

@fevangelou
Copy link
Member

Let's drop the CSS class. We'll add a notice in the release notes about it. Those who had the class on their overrides won't see a difference as the new initialization method is backwards compatible and will trigger the new modal. Obviously people who had the "modal" class so far either didn't use Bootstrap or they had used a workaround all this time.

So you @kavadas and @kricore you are both right :)

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants