This repository has been archived by the owner on Jan 25, 2021. It is now read-only.
Structure field: adds sort & flip option, fix #722 #749
Closed
distantnative
wants to merge
6
commits into
getkirby-v2:develop
from
distantnative:feature/structurefield-sort
Closed
Structure field: adds sort & flip option, fix #722 #749
distantnative
wants to merge
6
commits into
getkirby-v2:develop
from
distantnative:feature/structurefield-sort
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `sort` and `flip` option for structure fields ```php structurefield: label: Structure with sort and flip type: structure sort: ordernumber flip: true fields: a: label: A type: text b: label: B type: text ordernumber: label: Order # type: number ```
distantnative
changed the title
Structure field: adds sort & flip option, fix #722
[WIP] Structure field: adds sort & flip option, fix #722
Feb 6, 2016
distantnative
changed the title
[WIP] Structure field: adds sort & flip option, fix #722
Structure field: adds sort & flip option, fix #722
Feb 6, 2016
Ok ready to be considered |
I think it should also be unsortable when flip is enabled. |
Now also works with multiple sort fields and sort direction: ``` sort: fieldone, asc, fieldtwo, desc ```
Any idea when this is going to be implemented (I don't see a Milestone attached yet)? I'm eager to have this in one of my projects :). |
I don't know for sure but I guess it's probably not going to make it into 2.3 anymore. You could make a copy of the structure field with the changes of the pull request and put it into /site/fields to overwrite the original structure field. |
I'd like to push this up again. Would be great if this feature would be integrated into the structure without modal ... |
I have implemented this on the develop branch because the original PR wasn't auto-mergable. I did some refactoring on the way. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
sort
andflip
option for structure fields (fixes #722 and #652 )Update:
Also works with multiple sort fields and sort direction:
More changes to do