Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security page #969

Merged
merged 6 commits into from Jun 4, 2020
Merged

Security page #969

merged 6 commits into from Jun 4, 2020

Conversation

lukasbestle
Copy link
Member

This will also be used by the planned update checker. Also see getkirby/kirby#2627 (comment).

@distantnative
Copy link
Member

I like it!
But wondering about the „supported“ phrasing being tied to security incidents. The v3 supported/recommended version would always be the latest bugfix release - no matter if security fix or other bugfix, won’t it?

@lukasbestle
Copy link
Member Author

lukasbestle commented Jun 3, 2020

@distantnative I agree and I‘ve done it like that in the content file. But now I see that I forgot to change the description in the JSON template.

Or do you mean the headline/JSON key in general? If so: Any ideas what would be a better term?

@distantnative
Copy link
Member

Don’t really know a better one 😂 I think it’s fine

@lukasbestle lukasbestle merged commit 6009e11 into master Jun 4, 2020
@lukasbestle lukasbestle deleted the lukasbestle/security-page branch June 4, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants