First steps code splitting with Vite 3

getkirby · Aug 4, 2022 · 5a537cb · 5a537cb
1 parent 2c787e6
commit 5a537cb
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 25 deletions.
diff --git a/panel/dist/js/index.js b/panel/dist/js/index.js
diff --git a/panel/dist/js/vendor.js b/panel/dist/js/vendor.js
diff --git a/panel/dist/js/vuedraggable.js b/panel/dist/js/vuedraggable.js
diff --git a/panel/package-lock.json b/panel/package-lock.json
diff --git a/panel/package.json b/panel/package.json
@@ -39,7 +39,7 @@
 		"@vue/test-utils": "^1.3.0",
 		"autoprefixer": "^10.4.7",
 		"c8": "^7.11.3",
-		"cypress": "^10.3.0",
+		"cypress": "^10.4.0",
 		"eslint": "^8.16.0",
 		"eslint-config-prettier": "^8.5.0",
 		"eslint-plugin-cypress": "^2.12.1",

diff --git a/panel/src/components/Forms/Writer/Writer.vue b/panel/src/components/Forms/Writer/Writer.vue
@@ -160,8 +160,8 @@ export default {
 				link: (editor) => {
 					this.$refs.linkDialog.open(editor.getMarkAttrs("link"));
 				},
-				email: () => {
-					this.$refs.emailDialog.open(this.editor.getMarkAttrs("email"));
+				email: (editor) => {
+					this.$refs.emailDialog.open(editor.getMarkAttrs("email"));
 				},
 				paste: this.paste,
 				toolbar: (toolbar) => {
@@ -174,13 +174,13 @@ export default {
 					}
 				},
 				update: (payload) => {
-					if (!this.editor) {
+					if (!payload.editor) {
 						return;
 					}
 
 					// compare documents to avoid minor HTML differences
 					// to cause unwanted updates
-					const jsonNew = JSON.stringify(this.editor.getJSON());
+					const jsonNew = JSON.stringify(payload.editor.getJSON());
 					const jsonOld = JSON.stringify(this.json);
 
 					if (jsonNew === jsonOld) {

diff --git a/panel/src/components/Misc/Draggable.vue b/panel/src/components/Misc/Draggable.vue
@@ -16,8 +16,6 @@
 </template>
 
 <script>
-import Draggable from "vuedraggable/src/vuedraggable";
-
 /**
  * The Draggable component implements the
  * [Vue.Draggable](https://github.com/SortableJS/Vue.Draggable)
@@ -33,7 +31,7 @@ import Draggable from "vuedraggable/src/vuedraggable";
  */
 export default {
 	components: {
-		draggable: Draggable
+		draggable: () => import("vuedraggable/src/vuedraggable")
 	},
 	props: {
 		data: Object,