Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with exactly PHP 7.1.0 #1484

Closed
ralfgoeke opened this issue Feb 15, 2019 · 4 comments
Closed

Not working with exactly PHP 7.1.0 #1484

ralfgoeke opened this issue Feb 15, 2019 · 4 comments
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@ralfgoeke
Copy link

Kirby is not working, when the PHP Version is exactly 7.1.0.
Is this the desired behaviour because for some reason 7.1.0 is not sufficient?

Can be fixed line 7 in kirby/bootstrap.php like so otherwise:

// old
if (version_compare(PHP_VERSION, '7.1.0', '>') === false) {

// new
if (version_compare(PHP_VERSION, '7.1.0', '>=') === false) {
@ralfgoeke
Copy link
Author

Update: Panel seems to demand 7.1.1 at least as well, not sure where to fix that though. ;)

@lukasbestle
Copy link
Member

Hm, good question. That's something for @bastianallgeier.

The other place is here BTW:

https://github.com/getkirby/kirby/blob/3.0.1/src/Cms/System.php#L337

@bastianallgeier bastianallgeier added this to the 3.0.3 milestone Feb 18, 2019
@bastianallgeier
Copy link
Member

Nope, that's not desired but a stupid mistake. I will fix it asap.

@bastianallgeier bastianallgeier added the type: bug 🐛 Is a bug; fixes a bug label Feb 18, 2019
@lukasbestle lukasbestle removed the needs: discussion 🗣 Requires further discussion to proceed label Feb 18, 2019
bastianallgeier added a commit that referenced this issue Feb 20, 2019
@bastianallgeier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants