Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel] Login: don't show error "Invalid authentication token" #182

Closed
distantnative opened this issue Feb 23, 2018 · 4 comments
Closed

[Panel] Login: don't show error "Invalid authentication token" #182

distantnative opened this issue Feb 23, 2018 · 4 comments
Assignees
@bastianallgeier
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone
Alpha 7

Comments

@distantnative
Copy link
Member

distantnative commented Feb 23, 2018 •
edited by bastianallgeier

Shouldn't we show something less technical in this case?

Depends on: https://github.com/k-next/starterkit/issues/246
@bastianallgeier
Copy link
Member

Where do you get the error? The login should normally have a more "human" error already. But we need to work on error messages anyhow.

@distantnative
Copy link
Member Author

When switching browsers, returning to Safari and trying e.g. go to …/panel/, I get redirected to …/panel/login/ and this error message is shown.

@bastianallgeier
Copy link
Member

Ah, right! Yes, we should make it more human :)

@distantnative distantnative added this to the Beta milestone Feb 23, 2018
@distantnative distantnative removed their assignment Feb 23, 2018
@distantnative distantnative added type: enhancement ✨ Suggests an enhancement; improves Kirby and removed type: enhancement ✨ labels Feb 25, 2018
@bastianallgeier bastianallgeier changed the title Login: don't show error "Invalid authentication token" [Panel] Login: don't show error "Invalid authentication token" Mar 17, 2018
@bastianallgeier bastianallgeier modified the milestones: Beta 1, Alpha 7 Mar 17, 2018
@bastianallgeier
Copy link
Member

✅

distantnative pushed a commit that referenced this issue May 24, 2023
@bastianallgeier
Merge pull request #182 from getkirby/refactor/query-strict-types
90657de 
Strict types for `Query` package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bastianallgeier bastianallgeier

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
Alpha 7
Development

No branches or pull requests
2 participants
@bastianallgeier @distantnative